Add comments to spiral generation code (surrounding v3, which is where the most significant performance is gained). Change gnal_v2 to use library gnal_v2.scad

This commit is contained in:
mmcwilliams 2020-05-25 19:07:02 -04:00
parent f09960f3d7
commit 17afd6b5a6
5 changed files with 17 additions and 4 deletions

View File

@ -1,6 +1,6 @@
//V2 //V2
include <../libraries/gnal.scad>; include <../libraries/gnal_v2.scad>;
SPOKE_COUNT = 24; SPOKE_COUNT = 24;
PART=""; PART="";

View File

@ -1,6 +1,6 @@
//V2 //V2
include <../libraries/gnal.scad>; include <../libraries/gnal_v2.scad>;
$fn = 20; $fn = 20;

View File

@ -5,6 +5,14 @@ $fn=FN;
include <../libraries/path_extrude.scad>; include <../libraries/path_extrude.scad>;
/**
* This approach is the fastest by far (!!!). Unlike spiral_4, this does not adjust
* the $fn value as the spiral grows in diameter, but simply uses it as a constant
* for all spirals. This means that the innermost spiral will have n=$fn facets and
* the outermost facets will have the same number. Need to find a hybrid between
* this and #4.
**/
module spiral (count = 40, start_d = 48, spacing = 2.075) { module spiral (count = 40, start_d = 48, spacing = 2.075) {
//$fn = 80; //$fn = 80;

View File

@ -5,7 +5,9 @@ $fn=FN;
include <../libraries/path_extrude.scad>; include <../libraries/path_extrude.scad>;
//Distinction from v3: use of for loop and union to join rotations /**
* Distinction from spiral_3: use of for loop and union to join rotations.
**/
module spiral (count = 40, start_d = 48, spacing = 2.075) { module spiral (count = 40, start_d = 48, spacing = 2.075) {
facet_size = 30; facet_size = 30;

View File

@ -5,7 +5,10 @@ $fn=FN;
include <../libraries/path_extrude.scad>; include <../libraries/path_extrude.scad>;
//Distinction from v4 compressed spiralPath generation into single line /**
* Distinction from v4 compressed spiralPath generation into single line. This refactor
* required repeating calculations that were assigned to variables in spiral_4.
**/
module spiral (count = 40, start_d = 48, spacing = 2.095) { module spiral (count = 40, start_d = 48, spacing = 2.095) {
facet_size = 10; facet_size = 10;