16mm
/
GNAL
1
0
Fork 0
Code Issues 3 Pull Requests Projects Releases 3 Wiki Activity

Update comments on spiral code

This commit is contained in:
mmcwilliams 2020-05-27 09:52:15 -04:00
parent 1ff54374ae
commit 81c87f9b7d
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spiral/spiral_1.scad
View File

@ -32,7 +32,7 @@ module spiral (START_D = 50, SPIRALS = 39) {
/**
* Generates a single face of the spiral, in this case a trapazoidal
* shape. Issues are (1) performance (maybe use of hull()) and (2) all
* facet lenths are the same, despite the diameter. This means that
* facet counts are the same, despite the diameter. This means that
* there are excessive numbers of facets for the smaller spirals to
* compensate for the number of facets needed for the outer spiral.
*/

3
spiral/spiral_7.scad
View File

@ -30,7 +30,8 @@ function calcIncrement(spacing, fn) = spacing / fn;
/**
* spiral_7 - Combination of spiral_3 and spiral_4 that doesn't sacrifice
* performance. Hits an overflow when $fn is higher than 245 which creates
* 8418 vectors at 60 rotations. It's an edge casem
* 8418 vectors at 60 rotations. This is an edge case, only appearing in OpenSCAD
* 2019.05 (and maybe earlier), but should be explored.
**/
module spiral (rotations = 40, start_d = 48, spacing = 2.075, fn) {